Announcement

Symphony's issue tracker has been moved to Github.

Issues are displayed here for reference only and cannot be created or edited.

Browse

Closed#255: 2.0.7 - Symphony admin.js 'dictionary' system broken

I believe this has very likely been fixed in the integration branch, but this line in ‘admin.js’ which replaces spaces with underscores prior to searching:

(Line 27) var search = string.replace(/ /gi, ‘_’);

Inadvertently causes all of the default dictionary items that contain spaces (eg. ‘Remove File’) not to be found. They instead show as ‘undefined’ to the end user.

I thought a quick temporary fix for this (without having to refactor) was to change the line to:

(Line 27) var search = string;

Unfortunately this seems to cause additional issues on other pages with the ‘symphony.duplicator.js’ and pretty much completely breaks Symphony.

Changing the items in the dictionary object to include the underscores (eg. ‘Remove File’ to ‘Remove_File’) lets the objects get found, matches the strict equality test for false and then subsequently returns the original string (‘Remove File’) making it appear correctly for the end user, but I’m unsure if this is what was intended and mysteriously left out of 2.0.7.

This is a known problem, and here is the fix:

http://github.com/nilshoerrmann/symphony-2/commit/4b06aeb902d1464535790c89cfcdb39618a58b4b

You can simply replace those two files:

  • symphony/assets/admin.js
  • symphony/content/content.ajaxtranslate.php

Thanks michael-e, files replaced and all working as expected.

Can this fix please be pulled into the official 2.0.7 repo?

It’s probably not good policy to silently roll changes into an existing version, so the plan is to have outstanding 2.0.7 bugfixes go into a 2.0.8 release.

This issue is closed.

Symphony • Open Source XSLT CMS

Server Requirements

  • PHP 5.3-5.6 or 7.0-7.3
  • PHP's LibXML module, with the XSLT extension enabled (--with-xsl)
  • MySQL 5.5 or above
  • An Apache or Litespeed webserver
  • Apache's mod_rewrite module or equivalent

Compatible Hosts

Sign in

Login details